From f5fceb6d3a1c2db283bb76600b4a8df66727981d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20Sch=C3=B6ne?= Date: Wed, 11 Nov 2026 17:24:04 +0100 Subject: [PATCH 1/2] fix(sqlite): Extract columns from CREATE TABLE AS clause --- internal/engine/sqlite/convert.go | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/internal/engine/sqlite/convert.go b/internal/engine/sqlite/convert.go index dad36d4d1e..14f195eaf2 100644 --- a/internal/engine/sqlite/convert.go +++ b/internal/engine/sqlite/convert.go @@ -282,12 +282,21 @@ func columnTypeName(t *meyer.TypeName) string { } func (c *cc) convertCreateTableStmt(n *meyer.CreateTableStmt) ast.Node { + // CREATE TABLE ... AS SELECT takes its columns from the query, so it is + // recorded as a relation defined by that query. + if n.Select != nil { + return &ast.CreateTableAsStmt{ + Query: c.convert(n.Select), + Into: &ast.IntoClause{Rel: parseRangeVar(n.Name, nil)}, + IfNotExists: n.IfNotExists, + } + } stmt := &ast.CreateTableStmt{ Name: parseTableName(n.Name), IfNotExists: n.IfNotExists, // The node models none of these, so a statement carrying them has // no faithful rendering and the formatter keeps it as written. - Incomplete: n.Temp || n.Select != nil || len(n.Constraints) > 0 || len(n.Options) > 0, + Incomplete: n.Temp || len(n.Constraints) > 0 || len(n.Options) > 0, } for _, def := range n.Columns { if !representableColumn(def) { From 4424839762c6b0596671f56941b423be3318636e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20Sch=C3=B6ne?= Date: Wed, 11 Nov 2026 17:26:24 +0100 Subject: [PATCH 2/2] test(sqlite): Added create_table_as end-to-end test case --- .../testdata/create_table_as/sqlite/go/db.go | 31 ++++++++++++ .../create_table_as/sqlite/go/models.go | 22 +++++++++ .../create_table_as/sqlite/go/query.sql.go | 48 +++++++++++++++++++ .../testdata/create_table_as/sqlite/query.sql | 5 ++ .../create_table_as/sqlite/schema.sql | 5 ++ .../testdata/create_table_as/sqlite/sqlc.json | 12 +++++ 6 files changed, 123 insertions(+) create mode 100644 internal/endtoend/testdata/create_table_as/sqlite/go/db.go create mode 100644 internal/endtoend/testdata/create_table_as/sqlite/go/models.go create mode 100644 internal/endtoend/testdata/create_table_as/sqlite/go/query.sql.go create mode 100644 internal/endtoend/testdata/create_table_as/sqlite/query.sql create mode 100644 internal/endtoend/testdata/create_table_as/sqlite/schema.sql create mode 100644 internal/endtoend/testdata/create_table_as/sqlite/sqlc.json diff --git a/internal/endtoend/testdata/create_table_as/sqlite/go/db.go b/internal/endtoend/testdata/create_table_as/sqlite/go/db.go new file mode 100644 index 0000000000..32faa9f2b8 --- /dev/null +++ b/internal/endtoend/testdata/create_table_as/sqlite/go/db.go @@ -0,0 +1,31 @@ +// Code generated by sqlc. DO NOT EDIT. +// versions: +// sqlc v1.31.1 + +package querytest + +import ( + "context" + "database/sql" +) + +type DBTX interface { + ExecContext(context.Context, string, ...any) (sql.Result, error) + PrepareContext(context.Context, string) (*sql.Stmt, error) + QueryContext(context.Context, string, ...any) (*sql.Rows, error) + QueryRowContext(context.Context, string, ...any) *sql.Row +} + +func New(db DBTX) *Queries { + return &Queries{db: db} +} + +type Queries struct { + db DBTX +} + +func (q *Queries) WithTx(tx *sql.Tx) *Queries { + return &Queries{ + db: tx, + } +} diff --git a/internal/endtoend/testdata/create_table_as/sqlite/go/models.go b/internal/endtoend/testdata/create_table_as/sqlite/go/models.go new file mode 100644 index 0000000000..33b3968282 --- /dev/null +++ b/internal/endtoend/testdata/create_table_as/sqlite/go/models.go @@ -0,0 +1,22 @@ +// Code generated by sqlc. DO NOT EDIT. +// versions: +// sqlc v1.31.1 + +package querytest + +type CopyAll struct { + ID int64 + Val string + Score int64 +} + +type CopySome struct { + ID int64 + Label string +} + +type Foo struct { + ID int64 + Val string + Score int64 +} diff --git a/internal/endtoend/testdata/create_table_as/sqlite/go/query.sql.go b/internal/endtoend/testdata/create_table_as/sqlite/go/query.sql.go new file mode 100644 index 0000000000..6081e66090 --- /dev/null +++ b/internal/endtoend/testdata/create_table_as/sqlite/go/query.sql.go @@ -0,0 +1,48 @@ +// Code generated by sqlc. DO NOT EDIT. +// versions: +// sqlc v1.31.1 +// source: query.sql + +package querytest + +import ( + "context" +) + +const getCopySome = `-- name: GetCopySome :one +SELECT id, label FROM copy_some WHERE id = ? +` + +func (q *Queries) GetCopySome(ctx context.Context, id int64) (CopySome, error) { + row := q.db.QueryRowContext(ctx, getCopySome, id) + var i CopySome + err := row.Scan(&i.ID, &i.Label) + return i, err +} + +const listCopyAll = `-- name: ListCopyAll :many +SELECT id, val, score FROM copy_all +` + +func (q *Queries) ListCopyAll(ctx context.Context) ([]CopyAll, error) { + rows, err := q.db.QueryContext(ctx, listCopyAll) + if err != nil { + return nil, err + } + defer rows.Close() + var items []CopyAll + for rows.Next() { + var i CopyAll + if err := rows.Scan(&i.ID, &i.Val, &i.Score); err != nil { + return nil, err + } + items = append(items, i) + } + if err := rows.Close(); err != nil { + return nil, err + } + if err := rows.Err(); err != nil { + return nil, err + } + return items, nil +} diff --git a/internal/endtoend/testdata/create_table_as/sqlite/query.sql b/internal/endtoend/testdata/create_table_as/sqlite/query.sql new file mode 100644 index 0000000000..ae86ec402e --- /dev/null +++ b/internal/endtoend/testdata/create_table_as/sqlite/query.sql @@ -0,0 +1,5 @@ +-- name: ListCopyAll :many +SELECT * FROM copy_all; + +-- name: GetCopySome :one +SELECT id, label FROM copy_some WHERE id = ?; diff --git a/internal/endtoend/testdata/create_table_as/sqlite/schema.sql b/internal/endtoend/testdata/create_table_as/sqlite/schema.sql new file mode 100644 index 0000000000..0a48094409 --- /dev/null +++ b/internal/endtoend/testdata/create_table_as/sqlite/schema.sql @@ -0,0 +1,5 @@ +CREATE TABLE foo (id INTEGER PRIMARY KEY, val TEXT NOT NULL, score INTEGER NOT NULL); + +CREATE TABLE copy_all AS SELECT * FROM foo; + +CREATE TABLE IF NOT EXISTS copy_some AS SELECT id, val AS label FROM foo WHERE score > 0; diff --git a/internal/endtoend/testdata/create_table_as/sqlite/sqlc.json b/internal/endtoend/testdata/create_table_as/sqlite/sqlc.json new file mode 100644 index 0000000000..f8e8051087 --- /dev/null +++ b/internal/endtoend/testdata/create_table_as/sqlite/sqlc.json @@ -0,0 +1,12 @@ +{ + "version": "1", + "packages": [ + { + "engine": "sqlite", + "path": "go", + "name": "querytest", + "schema": "schema.sql", + "queries": "query.sql" + } + ] +} \ No newline at end of file