From 83a7174b642c2b574fa838f898aeba62c69e06bc Mon Sep 17 00:00:00 2001 From: sergeyb Date: Fri, 13 Nov 2026 20:46:50 +0000 Subject: [PATCH] docs(consumer): explain rejection of invalid queue metadata Summary: Document why invalid queue metadata is logged and rejected without retry. Changes: Explain permanent input errors and possible delivery drop without a later dead-letter queue. Queue handling and diagnostics are unchanged. Test Plan: Existing consumer and SQL queue unit tests and consumer integration tests. Formatting, lint, and dependency checks. Revert Plan: Remove the comment; existing queue handling remains unchanged. --- platform/consumer/consumer.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/platform/consumer/consumer.go b/platform/consumer/consumer.go index 7aab1b906..8240f16c3 100644 --- a/platform/consumer/consumer.go +++ b/platform/consumer/consumer.go @@ -289,6 +289,9 @@ func (m *consumer) consumeLoop(ctx context.Context, controller Controller, topic partitionChs := make(map[entityqueue.PartitionIdentity]chan extqueue.Delivery) var wg sync.WaitGroup + // Unchanged invalid metadata is a permanent input error; the failure is logged + // for operator investigation. Without a downstream DLQ, rejection may acknowledge + // and drop the delivery without retry. for { select { case <-ctx.Done():