Skip to content

[PWGEM] LMee: Adding nSigmaMu to the data model and the corresponding… - #18700

Draft
jjungIKF wants to merge 1 commit into
AliceO2Group:masterfrom
jjungIKF:master
Draft

jjungIKF wants to merge 1 commit into
AliceO2Group:masterfrom
jjungIKF:master

Conversation

@jjungIKF

Copy link
Copy Markdown
Contributor

… rejection criteria.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2000 warnings, 🔕 0 disabled

@alibuild

alibuild commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 317ddba at 2026-11-12 02:37:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 6 errors and 157 warnings.'
Found 6 errors and 157 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/121cf3e80cf768dc2cbb4f55667da9a306ae5746/O2Physics-code-check/errors.txt
PWGEM/Dilepton/TableProducer/Converters/electronConverter7.cxx:77:41: error: unknown type name 'electronConverter6'; did you mean 'electronConverter7'? [clang-diagnostic-error]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronQC.cxx:286:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx:305:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectron.cxx:1252:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/Utils/ElectronModule.h:394:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
PWGEM/Dilepton/Utils/ElectronModule.h:419:24: error: variable length arrays in C++ are a Clang extension [clang-diagnostic-vla-cxx-extension,-warnings-as-errors]
++ [[ 157 -gt 0 ]]
++ cat /sw/BUILD/121cf3e80cf768dc2cbb4f55667da9a306ae5746/O2Physics-code-check/warnings.txt
PWGEM/Dilepton/Core/DielectronCut.h:45:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Core/DielectronCut.h:52:3: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
PWGEM/Dilepton/Core/DielectronCut.h:52:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
PWGEM/Dilepton/Core/DielectronCut.h:161:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGEM/Dilepton/Core/DielectronCut.h:323:7: warning: switch has 2 consecutive identical branches [bugprone-branch-clone]
PWGEM/Dilepton/Core/DielectronCut.h:422:11: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGEM/Dilepton/Core/DielectronCut.h:485:8: warning: function 'DielectronCut::SetMindEtadPhi' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGEM/Dilepton/Core/DielectronCut.h:553:3: warning: function 'IsPhotonConversionSelected' should be marked [[nodiscard]] [modernize-use-nodiscard]
PWGEM/Dilepton/Core/DielectronCut.h:564:45: warning: initializer for member 'mMaxMeePhiVDep' is redundant [readability-redundant-member-init]
PWGEM/Dilepton/Core/DielectronCut.h:600:45: warning: initializer for member 'mMaxDcaXYPtDep' is redundant [readability-redundant-member-init]
PWGEM/Dilepton/Core/DielectronCut.h:631:29: warning: initializer for member 'mMLBins' is redundant [readability-redundant-member-init]
PWGEM/Dilepton/Core/DielectronCut.h:632:29: warning: initializer for member 'mMLCuts' is redundant [readability-redundant-member-init]
PWGEM/Dilepton/Core/DileptonMC.h:82:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Core/DileptonMC.h:108:8: warning: constructor does not initialize these fields: ccdb, mRunNumber, d_bz [cppcoreguidelines-pro-type-member-init]
PWGEM/Dilepton/Core/DileptonMC.h:335:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:336:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:337:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:359:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:361:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
PWGEM/Dilepton/Core/DileptonMC.h:451:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:452:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:454:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:455:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:457:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:458:22: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Core/DileptonMC.h:517:32: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGEM/Dilepton/Core/DileptonMC.h:667:39: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Core/DileptonMC.h:668:43: warning: use nullptr [modernize-use-nullptr]
[0 more errors; see full log]

Full log here.

@vkucera
vkucera marked this pull request as draft November 15, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants