Skip to content

[PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity - #18744

Open
eishahranipinstech-spec wants to merge 5 commits into
AliceO2Group:masterfrom
eishahranipinstech-spec:flattenicity-final-clean
Open

eishahranipinstech-spec wants to merge 5 commits into
AliceO2Group:masterfrom
eishahranipinstech-spec:flattenicity-final-clean

Conversation

@eishahranipinstech-spec

Copy link
Copy Markdown

FlattenicityStudy by FT0

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 10 warnings, 🔕 0 disabled

@eishahranipinstech-spec eishahranipinstech-spec changed the title [Infrastructure,PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity [PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity Nov 13, 2026
@eishahranipinstech-spec

Copy link
Copy Markdown
Author

@omvazque Hi, please merge my this clean version of code. Thanks

@eishahranipinstech-spec

Copy link
Copy Markdown
Author

@mpuccio Hi, please merge my code. Thanks

Comment thread PWGMM/UE/Tasks/flattenicityTask.cxx Resolved
@vkucera

vkucera commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

@omvazque Hi, please merge my this clean version of code. Thanks

You just created the PR. The code owners are requested automatically to review it. There is no need to address them explicitly.

Also please stop duplicating your PRs.

Most importantly, please read the contribution guidelines.

omvazque
omvazque previously approved these changes Nov 15, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for bbe10ab at 2026-11-15 19:31:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 8 errors and 77 warnings.'
Found 8 errors and 77 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/5494510c43a7a6a9145efe59582f4ad5e3afc967/O2Physics-code-check/errors.txt
PWGMM/UE/Tasks/flattenicityTask.cxx:17:1: error: included header inelGt.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:20:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:27:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:38:1: error: included header TH1.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:43:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:65:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:409:39: error: no header providing "uint8_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:471:49: error: no header providing "int64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 77 -gt 0 ]]
++ cat /sw/BUILD/5494510c43a7a6a9145efe59582f4ad5e3afc967/O2Physics-code-check/warnings.txt
PWGMM/UE/Tasks/flattenicityTask.cxx:117:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:118:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:119:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:120:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:128:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:129:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:184:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:184:46: warning: use designated initializer list to initialize 'PtSegment' [modernize-use-designated-initializers]
PWGMM/UE/Tasks/flattenicityTask.cxx:184:63: warning: use designated initializer list to initialize 'PtSegment' [modernize-use-designated-initializers]
PWGMM/UE/Tasks/flattenicityTask.cxx:184:79: warning: use designated initializer list to initialize 'PtSegment' [modernize-use-designated-initializers]
PWGMM/UE/Tasks/flattenicityTask.cxx:184:95: warning: use designated initializer list to initialize 'PtSegment' [modernize-use-designated-initializers]
PWGMM/UE/Tasks/flattenicityTask.cxx:286:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:288:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:297:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:299:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:302:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:316:20: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:325:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:331:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:356:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:375:114: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:395:112: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:454:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:456:43: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:460:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:462:82: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

@eishahranipinstech-spec Please fix the errors before merging.
@omvazque Please make sure the errors are fixed before merging.

@eishahranipinstech-spec

eishahranipinstech-spec commented Nov 15, 2026 •

Copy link
Copy Markdown
Author

@eishahranipinstech-spec Please fix the errors before merging. @omvazque Please make sure the errors are fixed before merging.

Hi @vkucera @omvazque done from myside, you can check now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants