Skip to content

[PWGJE] Added weighted-MC processes for jet background analysis - #18754

Open
choich08365 wants to merge 1 commit into
AliceO2Group:masterfrom
choich08365:gnnbjet
Open

choich08365 wants to merge 1 commit into
AliceO2Group:masterfrom
choich08365:gnnbjet

Conversation

@choich08365

Copy link
Copy Markdown
Contributor

Dear @aimeric-landou, @nzardosh, and @YubiaoWang,

I've drafted an update to the jet background analysis task, which enables the analysis on jet–jet MC. Could you please review it when you have time?
Thanks in advance!

PWGJE/Tasks/jetBackgroundAnalysis.cxx

  • Add processRhoMCDWeighted, processRhoMCPWeighted, processBkgFluctuationsMCDWeighted, and processBkgFluctuationsMCPWeighted.
  • Apply weighted MC outlier rejection using JCollisionOutliers and JMcCollisionOutliers.
  • Add applyMCDSelectionToMCP option. When enabled, require the matched MCD collision to pass the same event selection as MCD processes. This change is necessary for validating the unfolding of jet pT spectra with underlying-event subtraction, in my opinion.
  • Apply particle selections consistently to random-cone calculations.

PWGJE/Core/JetFindingUtilities.h

  • Extract particle status and charge selections from analyseParticles into the shared isParticleSelected function.

@github-actions github-actions Bot added the pwgje label Nov 15, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 12 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Added weighted-MC processes for jet background analysis [PWGJE] Added weighted-MC processes for jet background analysis Nov 15, 2026
@choich08365
choich08365 marked this pull request as ready for review November 15, 2026 12:21
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0782eb3 at 2026-11-15 13:58:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 8 warnings.'
Found 2 errors and 8 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/7d754585e85507907fd9c89ee68fa9425526b35b/O2Physics-code-check/errors.txt
PWGJE/Core/JetFindingUtilities.h:41:1: error: included header utility is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:255:96: error: no header providing "JetType" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/7d754585e85507907fd9c89ee68fa9425526b35b/O2Physics-code-check/warnings.txt
PWGJE/Core/JetFindingUtilities.h:44:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Core/JetFindingUtilities.h:272:12: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGJE/Core/JetFindingUtilities.h:273:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetFindingUtilities.h:346:80: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGJE/Core/JetFindingUtilities.h:348:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Core/JetFindingUtilities.h:428:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:48:8: warning: constructor does not initialize these fields: pdgDatabase [cppcoreguidelines-pro-type-member-init]
PWGJE/Tasks/jetBackgroundAnalysis.cxx:75:24: warning: initializer for member 'randomNumber' is redundant [readability-redundant-member-init]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants