Repository navigation
[PWGCF] Handle kSecondaryFromPhi in the FemtoDream QA history - #18757
Open
Alascraker wants to merge 1 commit into
Open
Alascraker wants to merge 1 commit into
Alascraker wants to merge 1 commit into
Conversation
kSecondaryFromPhi was added together with kSecondaryFromHF/LF, but the FemtoDream QA switch statements did not know it, so any V0 candidate from a phi decay chain hit the fatal branch in fillQA_MC and killed the whole workflow. - add hCPA_SecondaryFromHF/LF/Phi registration for V0 candidates - add the three cases to both V0 switches (debug and non-debug) - add the Phi case and its histograms to the kaon switches Note: the cascade branches keep their pre-existing gap for the HF/LF/Phi origins; they are not touched here to keep the scope minimal.
Alascraker
requested review from
alibuild,
ariedel-cern,
dimihayl,
dsarkaralice,
lauraser,
victor-gonzalez and
wrzesaCERN
as code owners
November 15, 2026 13:06
|
O2 linter results: ❌ 0 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
kSecondaryFromPhiorigin was introduced together withkSecondaryFromHF/LF, but the FemtoDream QA switch statements were not updated accordingly.Since
fillQA_MCtreats every unknownParticleOriginMCTruthvalue as fatal (LOG(fatal)), any V0 candidate coming from aphi -> K0/K0bar -> K0Schain killed the whole workflow:This was seen in HF MC trains (
LHC26g5, taskhf-task-charm-hadrons-v0-femto-dream) as soon as a feed-down K0S from a phi was selected, and it takes down the whole DPL workflow.Changes
Single file,
PWGCF/FemtoDream/Core/femtoDreamParticleHisto.h:hCPA_SecondaryFromHF/LF/Phiregistrations for V0 candidates (debug and non-debug)kSecondaryFromPhicase and its histograms (hDCAxy_SecondaryFromPhi,Debug/hPDGmother_SecondaryFromPhi) to the kaon switchesVerification
Static, since the local setup cannot run the full train chain:
PWGHF/HFC/TableProducer/producerCharmHadronsV0FemtoDream.cxx) can write eight values for V0:kPrimary,kMaterial,kFake,kWrongCollision,kElse,kSecondaryFromHF/LF/Phi; all of them have a case after this patch, so the fataldefaultis unreachable for this producerNotes
PWGCF/FemtoUniverse/Core/FemtoUniverseParticleHisto.hhas the same gap, but it only logs atinfolevel there, so it does not crash