Repository navigation
fix(display): a new tab from a standalone window opens in the main window - #4023
Open
emilioheredia-source wants to merge 1 commit into
Open
emilioheredia-source wants to merge 1 commit into
emilioheredia-source wants to merge 1 commit into
Conversation
…ndow A standalone window never shows its tab bar. A display opened in a new tab from there, by an action or a Ctrl-click, covered the current display, and there was no way back to it. Open the new tab in the main window instead and bring that window to the front, as is already done for applications started from a standalone window. A named pane that exists is still used; a new named pane is split off the main window. When the main window can't take the tab, for example because its pane is locked, open the display in a new window.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of #3543, option (a) there.
A standalone window shows no tabs. A display opened in a new tab from there, by an Open Display action or a Ctrl-click, went into the standalone window and covered the current display, with no way back to it.
Now the new tab opens in the main window, which is brought to the front, as for applications started from a standalone window. The standalone window stays as it was.
The change is in
DockItemRepresentation.openPanel(). It also removes the trailing whitespace of one line in that file, which the pre-commit check asks for.Checklist
StandaloneNewTabUI(TestFX): a new tab from a standalone window, from a normal window, and from a standalone window while the main window's pane is locked. The first and the last fail on master. Theui-testsprofile currently runs no tests (failsafe 2.22.0 doesn't discover JUnit 5 tests with the current JUnit platform), so the test was run with surefire under Xvfb, together with the module tests.