Skip to content

feat(display): EDM converter preference for the target of related displays - #4024

Open
emilioheredia-source wants to merge 1 commit into
ControlSystemStudio:masterfrom
emilioheredia-source:display/edm-related-display-target
Open

emilioheredia-source wants to merge 1 commit into
ControlSystemStudio:masterfrom
emilioheredia-source:display/edm-related-display-target

Conversation

@emilioheredia-source

Copy link
Copy Markdown

Part of #3543, item 2 there.

EDM opens a related display in a new window, and the EDM converter maps that to a new tab. A new converter preference selects the target instead:

org.csstudio.display.converter.edm/related_display_target=tab
  • tab (default, unchanged), window or standalone, as for the target of an Open Display action.
  • An unknown value logs a warning and keeps tab.
  • A related display with "close display" set still replaces the current display.

As @rjwills28 pointed out in #3543, the OPI converter already maps these displays to windows; this gives the EDM converter the same choice.

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • RelatedDisplayTargetTest: reading the setting, the default target, and the standalone target, with a small EDM file that has a related display with and without "close display". EDM converter module tests pass.
  • Documentation:

    • The feature is documented (in edm_converter_preferences.properties, which the preference listing of the docs is built from)
    • The documentation is up to date

…plays

EDM opens a related display in a new window, which the converter maps
to a new tab. The new preference related_display_target selects tab
(default, unchanged), window or standalone instead, written as for the
target of an Open Display action. An unknown value logs a warning and
keeps tab. Related displays with 'close display' set still replace the
current display.
@emilioheredia-source
emilioheredia-source force-pushed the display/edm-related-display-target branch from 6c6cfab to fdddcfd Compare November 15, 2026 17:07
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants