Skip to content

fix: --check diagnoses every file twice #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rathoz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: --check diagnoses every file twice #3499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased
<!-- Add all new changes here. They will be moved under a version at release -->
* `FIX` `--check` no longer diagnoses every file twice

## 3.19.2
`2026-10-13`
Expand Down
2 changes: 0 additions & 2 deletions script/cli/check_worker.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ local lclient = require 'lclient'()
local furi = require 'file-uri'
local ws = require 'workspace'
local files = require 'files'
local diag = require 'provider.diagnostic'
local util = require 'utility'
local jsonb = require 'json-beautify'
local lang = require 'language'
Expand Down Expand Up @@ -249,7 +248,6 @@ function export.runCLI()
for i, uri in ipairs(uris) do
if (i % numThreads + 1) == threadId and not ws.isIgnored(uri) then
files.open(uri)
diag.doDiagnostic(uri, true)
-- Print regularly but always print the last entry to ensure
-- that logs written to files don't look incomplete.
if not quiet and (os.clock() - lastClock > 0.2 or i == #uris) then
Expand Down
Loading