Repository navigation
fix(runtime): read the nsbundle_pack sealing key from NS_BUNDLE_KEY_HEX - #47
Merged
Merged
Conversation
Command lines show up in process lists and in process-creation audit logs. --key-hex keeps working for CLIs that pass it.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nsbundle_packonly accepts the source-protection key as--key-hex <64 hex>. A process's command line is visible to other processes and is recorded by process-creation auditing (Event 4688, Sysmon, Defender), so the key ends up in logs.This adds
NS_BUNDLE_KEY_HEXas another way to pass the key:--key-hexnor--write-keyis given; an empty value is ignored--key-hexand--write-keybehave exactly as before--helpmentions the variable, so callers can detect supportThe NativeScript CLI checks
nsbundle_pack --helpforNS_BUNDLE_KEY_HEX. It passes the key through the environment when the tool supports it and falls back to--key-hexotherwise, so the CLI and the runtime can be updated in either order.