Repository navigation
[MIG] base_export_async: Migration to 17.0 - #894
StephaneMangin wants to merge 62 commits into
Conversation
…achment to a record only visible to the user
Currently translated at 100.0% (19 of 19 strings) Translation: queue-12.0/queue-12.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-base_export_async/de/
Currently translated at 100.0% (19 of 19 strings) Translation: queue-12.0/queue-12.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-base_export_async/zh_Hans/
The UI still send it to the current user, but it will allow reusing the module for other purposes: plan a regular export to users. Setting the recipient_ids instead of the email_to in mail.mail means that we can still send the email, it will stay in the failed emails, allowing to correct the user.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: queue-12.0/queue-12.0-base_export_async Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-base_export_async/
0ac5649 to
4f73e1b
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
with your changes an async excel export will look slightly differently from what you get without async, I don't this this should be the case.
In my opinion, the excel export changes should go to another module that applies these changes in a way that's independent of base_export_async, and the migration keep the contract of: do the same as in sync case, but asynchronously.
And please refrain from reformatting xml files without need, that makes the diff more noisy than necessary.
github-actions
Bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
4f73e1b to
1bf8955
Compare
|
The following commit authors need to sign the Contributor License Agreement:
|
|
#1032 included cc @samirGuesmi |
1bf8955 to
99f0dbe
Compare
99f0dbe to
80efdb4
Compare
During my tests, no visible changes but anyway.
XML untouched and In memory ExcelExport rollbacked. |
--Needed to monkey patch the env of request during data parsing as the export mechanism uses it under the hood and leads to ACLs exception while searching for currencies--
Reimplementing a part of the Export to avoid calling request which fails.
A patch on Odoo is planned.