Repository navigation
Update target framework to net10.0 - #38
Merged
Merged
Conversation
eddymoulton
commented
Nov 11, 2026
| os: [ windows-2022, windows-2025, macos-15, macos-26 ] | ||
| tfm: [ net472, net8.0, net10.0 ] | ||
| exclude: | ||
| - os: macos-14 |
Collaborator
Author
There was a problem hiding this comment.
macos-14 runners were deprecated earlier this month
eddymoulton
commented
Nov 11, 2026
| byte[] data = new byte[len]; | ||
| Marshal.Copy(new IntPtr(cert->data), data, 0, len); | ||
| #if NET9_0_OR_GREATER | ||
| Certificate = X509CertificateLoader.LoadCertificate(data); |
Collaborator
Author
There was a problem hiding this comment.
Only added in net9.0
NickJosevski
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream repo updated the tests to use
net10.0in libgit2#2186, but withnet8.0andnet9.0going EOL this week we want to update the library tonet10.0too.I've left
net8.0in temporarily to avoid requiring a precisely timed migration fornet8.0apps. We can removenet8.0shortly after.