Skip to content

Bring in fixes from 1.3.0 and 1.3.1 releases - #2085

Merged
Anam Navied (anamnavi) merged 7 commits into
masterfrom
1.3.1-release
Nov 10, 2026
Merged

Anam Navied (anamnavi) merged 7 commits into
masterfrom
1.3.1-release

Conversation

@anamnavi

Copy link
Copy Markdown
Member

PR Summary

Bring in fixes from 1.3.0 and 1.3.1 releases

PR Context

PR Checklist

Anam Navied added 7 commits November 2, 2026 18:27
…lease

Update ModuleVersion in module manifest for 1.3.0 release

----
#### AI description  (iteration 1)
#### PR Classification
Release preparation (module manifest version/release notes update).

#### PR Summary
Updates the module manifest to finalize the 1.3.0 release by removing the prerelease tag and adding release notes.
- `src/Microsoft.PowerShell.PSResourceGet.psd1`: commented out the `Prerelease = 'rc2'` tag, marking the module as a stable release.
- `src/Microsoft.PowerShell.PSResourceGet.psd1`: added a new `## 1.3.0` section header in `ReleaseNotes` above the previous `1.3.0-rc2` notes.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…lease

Update ModuleVersion in module manifest for 1.3.1 release
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@anamnavi

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unchecked package-version suffixes can allow writes outside the temporary directory, while credential-confirmation gates can bypass consent and incorrectly turn publish dry runs into terminating errors.

4 open issues
What changed in this PR

Brings the 1.3.0 and 1.3.1 release fixes into PSResourceGet, focusing on credential handling, package-name validation, and XML parsing safeguards.

Changes:

  • Updates the module manifest to stable version 1.3.1.
  • Separates repository-resolved credentials from explicitly supplied credentials and adds confirmation gates.
  • Adds remote package-name checks and restrictive XML reader settings.
File Description
src/​Microsoft.PowerShell.PSResourceGet.psd1 Sets version 1.3.1 and adds release-note headings.
src/​code/​V2ServerAPICalls.cs Hardens XML parsing for result counts.
src/​code/​V2ResponseUtil.cs Hardens V2 response XML parsing.
src/​code/​Utils.cs Adds remote-name validation and hardens nuspec parsing.
src/​code/​UpdatePSResource.cs Adds a credential-use confirmation gate.
src/​code/​SavePSResource.cs Adds a credential-use gate and raises confirmation impact.
src/​code/​PublishPSResource.cs Adds a gate for credentials with an implicit repository.
src/​code/​NuGetServerResponseUtil.cs Hardens NuGet.Server response XML parsing.
src/​code/​NuGetServerAPICalls.cs Hardens XML parsing for result counts.
src/​code/​LocalServerApiCalls.cs Hardens local nuspec XML parsing.
src/​code/​InstallPSResource.cs Adds a credential-use confirmation gate.
src/​code/​InstallHelper.cs Isolates repository credentials and validates package names.
src/​code/​FindPSResource.cs Enables confirmation support and adds a credential-use gate.
src/​code/​FindHelper.cs Prevents repository-resolved credentials from carrying between feeds.

Review effort: Balanced

Comment thread src/code/InstallHelper.cs Resolved
Comment thread src/code/FindPSResource.cs Resolved
Comment thread src/code/FindPSResource.cs Resolved
Comment thread src/code/PublishPSResource.cs Resolved
@anamnavi
Anam Navied (anamnavi) merged commit d536385 into master Nov 10, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants