You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(examples/solid): rename 'astro' to 'ssr-astro', replace '@astrojs/tailwind' with Tailwind CSS v4 via '@tailwindcss/vite', and align it with the current Astro template - #12585
Rename examples/solid/astro to examples/solid/ssr-astro to follow the <feature>-<framework> naming of the other examples. The example renders on the server (output: 'server') and shows whether each query was rendered on the server or the client. Update the package name, the docs/config.json link and label ("SSR (Astro)"), the README heading and the page title (TanStack Solid Query SSR Example (Astro)), and the lockfile importer.
Replace @astrojs/tailwind, whose astro peer range stops at v5 while the example uses astro 7, with Tailwind CSS v4 through @tailwindcss/vite, as the Astro Tailwind template does:
Add tailwindcss() to vite.plugins in astro.config.mjs.
Add src/styles/global.css with @import 'tailwindcss' and import it in MainLayout.astro.
Remove tailwind.config.mjs.
Update classes whose meaning changed in v4: rounded-sm → rounded-xs, rounded → rounded-sm, flex-shrink-0 → shrink-0, and add border-gray-200 to border, border-b and border-r, since the default border color is now currentColor.
Align the example with the current Astro minimal template:
tsconfig.json includes .astro/types.d.ts and **/* and excludes dist, which replaces src/env.d.ts and its ESLint ignore.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
No actionable comments were generated in the recent review.
Walkthrough
The Solid Astro example updates its Tailwind integration and project configuration. Its navigation labels and page title now identify it as an SSR example, and several component styles have changed.
Changes: Solid SSR Astro Example
Layer / File(s)
Summary
Update example tooling and styles examples/solid/ssr-astro/package.json, examples/solid/ssr-astro/astro.config.mjs, examples/solid/ssr-astro/src/styles/global.css, examples/solid/ssr-astro/src/layouts/MainLayout.astro, examples/solid/ssr-astro/tsconfig.json, examples/solid/ssr-astro/eslint.config.js, examples/solid/astro/src/env.d.ts, examples/solid/astro/tailwind.config.mjs, examples/solid/ssr-astro/.gitignore
The example replaces the Astro Tailwind integration with the Tailwind Vite plugin, updates Tailwind CSS to version 4, imports Tailwind in the global stylesheet, and updates TypeScript settings. It also removes the prior environment and Tailwind configuration files, the ESLint ignore entry, and the .vercel/ ignore entry.
Update example labels and navigation docs/config.json, examples/solid/ssr-astro/README.md, examples/solid/ssr-astro/src/layouts/MainLayout.astro
The navigation label and route, README heading, and page title identify the example as Solid Query SSR (Astro).
Adjust example component styles examples/solid/ssr-astro/src/components/SolidApp.tsx
The artwork container and sidebar gain borders. Stat bars, Pokémon links, and avatars use smaller corner radii; avatar and navigation sizing classes are updated.
TanStack/query#12583: This PR also edits the Solid Astro README and docs/config.json, so the README title changes may need to be reconciled.
Merge Risk: Minimal · up to ada79
This updates an example project's name, labels and Tailwind setup. No concrete merge-blocking risk was found, and the change does not affect shipped library code.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the rename from 'astro' to 'ssr-astro', which is the main change in the changeset. It also names the Tailwind CSS v4 migration via '@tailwindcss/vite' and the template alignment. The t…
Description check
The description follows the repository template. It has the Changes section with detailed bullets that explain the rename, the Tailwind CSS v4 migration, and the template alignment. The Checklist sect…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the rename from 'astro' to 'ssr-astro', which is the main change in the changeset. It also names the Tailwind CSS v4 migration via '@tailwindcss/vite' and the template alignment. The title is long (21 words, 171 characters) but these changes are all present in the diff, so it is related to the changeset.
Full details: Description check
Explanation
The description follows the repository template. It has the Changes section with detailed bullets that explain the rename, the Tailwind CSS v4 migration, and the template alignment. The Checklist section is filled in and marked. The Release Impact section marks the docs/CI/dev-only option. The description gives the motivation for each change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
examples/solid/astrotoexamples/solid/ssr-astroto follow the<feature>-<framework>naming of the other examples. The example renders on the server (output: 'server') and shows whether each query was rendered on the server or the client. Update the package name, thedocs/config.jsonlink and label ("SSR (Astro)"), the README heading and the page title (TanStack Solid Query SSR Example (Astro)), and the lockfile importer.@astrojs/tailwind, whoseastropeer range stops at v5 while the example usesastro7, with Tailwind CSS v4 through@tailwindcss/vite, as the Astro Tailwind template does:tailwindcss()tovite.pluginsinastro.config.mjs.src/styles/global.csswith@import 'tailwindcss'and import it inMainLayout.astro.tailwind.config.mjs.rounded-sm→rounded-xs,rounded→rounded-sm,flex-shrink-0→shrink-0, and addborder-gray-200toborder,border-bandborder-r, since the default border color is nowcurrentColor.tsconfig.jsonincludes.astro/types.d.tsand**/*and excludesdist, which replacessrc/env.d.tsand its ESLint ignore.startscript, which duplicateddev..vercel/from.gitignore.// @ts-checktoastro.config.mjs.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit