[peterolkhov]

🎯 Changes

An empty list with paddingStart: 40, paddingEnd: 60, and scrollMargin: 200 currently has a total size of 0. The same list with no scroll margin has its expected 100px of padding. Filtering a populated list to zero rows collapses that padding too.

The empty measurement endpoint now includes the scroll origin before the shared conversion to list-local size. This preserves configured padding without changing populated-list sizing or the nonnegative clamp from #836. Tests cover each padding side, count transitions, horizontal/two-lane layouts, disabled lists, and no-padding controls.

AI assistance was used to develop and validate this change.

✅ Checklist

• I have followed the steps in the Contributing guide.
• I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

• This change affects published code, and I have generated a changeset.
• This change is docs/CI/dev-only (no release).

Tested: pnpm run test:pr (69 affected projects, 124 uncached tasks) and pnpm run build:all passed. The browser suites passed 139 tests; unit suites passed 593, with one existing skip. A React/Chromium reproduction using built package exports retains the empty 100px list and its footer position.

Browser checks used cached Chromium 153.0.8010.12 with locked Playwright 1.56.1, rather than its bundled Chromium 141. No browser was downloaded.

Summary by CodeRabbit

• Bug Fixes
  • Corrected total-size calculations for empty lists with a nonzero scroll margin, preserving start and end padding across horizontal and vertical layouts.

[changeset-bot]

🦋 Changeset detected

Latest commit: 39b6005

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@tanstack/virtual-core	Patch
@tanstack/angular-virtual	Patch
@tanstack/lit-virtual	Patch
@tanstack/marko-virtual	Patch
@tanstack/react-virtual	Patch
@tanstack/solid-virtual	Patch
@tanstack/svelte-virtual	Patch
@tanstack/vue-virtual	Patch
@tanstack/virtual-benchmarks	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

For empty measurement lists, _getLayoutTotalSize now includes scrollMargin in the endpoint. Parameterized tests cover padding, orientation, lane count, and enabled states. A patch changeset records the update.

Changes: Empty-list total size

Layer / File(s)	Summary
Empty-list endpoint and regression coverage packages/virtual-core/src/index.ts, packages/virtual-core/tests/index.test.ts, .changeset/green-dodos-see.md	The empty-measurements endpoint now includes scrollMargin. Parameterized tests check total size across padding values, orientations, lane counts, and enabled states. A patch changeset records the change.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

• TanStack/virtual#1372: This PR changes the empty-list endpoint used by #1372 to track trailing scrollable space.
• TanStack/virtual#1340: This PR changes the empty-list layout total used by #1340 to calculate end distance.
• TanStack/virtual#1351: This PR changes the empty-list layout total used by #1351 to cap the range at the list’s end.

Suggested reviewers: piecyk

Merge Risk: Minimal · up to 39b60

Empty lists retain their configured padding with a scroll margin. No merge-blocking issue is identified; the change is ready for normal merge checks.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly summarizes the main change: preserving empty-list padding when scrollMargin is set.
Description check		The description explains the change and motivation, reports testing, and documents release impact with a changeset. The contributing-guide checklist item is unchecked, but the description is otherwise…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the change and motivation, reports testing, and documents release impact with a changeset. The contributing-guide checklist item is unchecked, but the description is otherwise complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/virtual-core/tests/index.test.ts

Parsing error: "parserOptions.project" has been provided for @typescript-eslint/parser.
The file was not found in any of the provided project(s): packages/virtual-core/tests/index.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: b34e69d0-065a-4db8-99c1-ac77e77a44f7

Commits

Reviewing files that changed from the base of the PR and between 54a3f7d and 39b6005.

Files selected for processing: 3

• .changeset/green-dodos-see.md
• packages/virtual-core/src/index.ts
• packages/virtual-core/tests/index.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

[agammann]

The new tests check getTotalSize() as count goes 4 → 0 → 4 with a scroll margin. Could one also check an end-anchored virtualizer’s scroll position when it becomes empty? The changed empty-list total feeds _drawnListEnd, so a correct total alone would not catch an unexpected end-anchor correction.