Repository navigation
Require Node.js 24.22.1 (CVE-2026-111497) - #154
Merged
Merged
Conversation
engines.node is raised to >=24.22.1, the first 24.x release where Node2Shell (CVE-2026-111497, the Brotli decoder in Node.js) is fixed. .npmrc with engine-strict=true makes npm refuse to install on an older Node instead of only warning.
Without check-latest, setup-node may use an older 24.x already cached on the runner, and it can be older than 24.22.1 where CVE-2026-111497 (Node2Shell) is fixed. With check-latest: true the latest 24.x is downloaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js before 24.22.1 has a flaw in its Brotli decoder that can allow
remote code execution when a compressed response is decoded
(CVE-2026-111497, also called Node2Shell or HTTP2Shell, see
https://nodejs.org/en/blog/vulnerability/october-2026-security-releases).
This plugin does not fetch anything itself. It reads from the HAR file,
so this change only makes sure it is installed, run and tested on a
patched Node.js.
Changes
>=24.15.0->>=24.22.1.engine-strict=true, sonpm installin this repositorystops on an older Node.js instead of warning.
.npmrcis not publishedto npm, so projects that install the plugin get the engines requirement
as a warning, unless they enable engine-strict themselves (webperf_core
does).
check-latest: trueon setup-node, so CI does not run on anolder Node.js 24.x cached on the runner.
WORKFLOW_LINE
Testing
Not run locally. CI on this PR runs the plugin on the updated setup.
After merging
webperf_core installs plugins by exact version. The new requirement
reaches webperf_core after a release here and a version bump there
(Dependabot opens that PR weekly).