Skip to content

refactor(server): use typed graph registry keys - #3482

Open
iiiiSaber wants to merge 1 commit into
apache:masterfrom
iiiiSaber:refactor/graph-manager-key
Open

iiiiSaber wants to merge 1 commit into
apache:masterfrom
iiiiSaber:refactor/graph-manager-key

Conversation

@iiiiSaber

Copy link
Copy Markdown

Purpose of the PR

Address the GraphManager FIXME by replacing combined string keys with typed graph identities.

Main Changes

  • Introduce the immutable GraphKey record.
  • Use typed keys for registry and lifecycle tracking.
  • Preserve string interfaces and the live graph-name view.
  • Add regression tests and update existing fixtures.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests.
  • Need tests and can be verified as follows:

128 focused tests passed, including four new regression tests. Formatting, full clean compilation, and git diff --check passed.

Does this PR potentially affect the following parts?

  • Dependencies
  • Modify configurations
  • The public API
  • Other affects: internal graph registry and lifecycle tracking.
  • Nope

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need: internal refactor.

- Introduce GraphKey for graph-space and graph-name identity.
- Migrate registry and lifecycle tracking to typed keys.
- Preserve string boundaries and the live graph-name view.
- Add registry regressions and adapt existing lifecycle fixtures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant