Repository navigation
Conversation
Fokko
approved these changes
Nov 15, 2026
Fokko
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @iceberg-kitten 🚀 Verified locally: the new test fails on main (reports a partial {1: 0} count) and passes with the fix. Matches the Java behavior in ParquetMetrics where an unknown chunk count propagates through addNullCount and the entry is omitted. All 20 tests in test_pyarrow_stats.py pass, ruff is clean.
ebyhr
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
null_value_countswhen any Parquet row group has no null count.Why
IS NULLscan skip a matching file.Implementation