Repository navigation
Keep identifier fields when renaming a struct that contains one - #4393
Open
Anurag-S1ngh wants to merge 1 commit into
Open
Anurag-S1ngh wants to merge 1 commit into
Anurag-S1ngh wants to merge 1 commit into
Conversation
Identifier fields are stored by field ID in the spec, but UpdateSchema kept them as dotted names while staging and only rewrote an exact name match on rename. Renaming a struct that holds an identifier field left the staged name pointing at the old path, so the commit failed with "Cannot find identifier field". Keep the identifier field IDs of the starting schema and resolve names passed to set_identifier_fields to IDs where they exist. Names that only exist after the update, such as newly added columns, are still resolved against the resulting schema at commit.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renaming a struct that contains an identifier field failed at commit with
Cannot find identifier field user.id, becauseUpdateSchemakept identifier fields as dotted names and only rewrote an exact name match on rename.Changes
set_identifier_fieldsto IDs where they exist, and keep resolving names that only exist after the update (such as newly added columns) against the resulting schema at commit.Testing
set_identifier_fields, and deleting an identifier field.make testpasses (4696 passed, 5 skipped).Closes #4373