Repository navigation
GH-3877: Add FINITE_VECTOR logical type support - #3876
Open
divjotarora wants to merge 18 commits into
Open
divjotarora wants to merge 18 commits into
divjotarora wants to merge 18 commits into
Conversation
divjotarora
marked this pull request as ready for review
October 22, 2026 10:39
divjotarora
changed the title
This was referenced Oct 30, 2026
Draft
divjotarora
changed the title
Fokko
requested changes
Nov 2, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
The biggest issue is around the validation. It feels to me that a lot of visitor that are meant to do other things, are now also validating if it is a valid FINITE_VECTOR. I left some other comments as well. Let me know what you think
Contributor
There was a problem hiding this comment.
Eventually, these should go in https://github.com/apache/parquet-testing/
Contributor
Author
There was a problem hiding this comment.
Yes, that's definitely the goal here
Fokko
reviewed
Nov 3, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Fokko
reviewed
Nov 5, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Thanks @divjotarora for iterating on this, I think we're getting close 👍 Now, my main concern is the performance penalty that we're having because of the validation.
Contributor
|
Another thing, I think we don't need to collect that much statistics for the vector:
We can also do this in a separate PR |
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The FINITE_VECTOR proposal defines fixed-size vectors of non-null, finite elements on canonical LIST storage, so applications can express vector semantics while retaining existing Parquet storage and interoperability. This change brings parquet-java support in line with the proposal.
What changes are included in this PR?
Adds FINITE_VECTOR schema annotations and mandatory write validation, validates stored levels and elements during reads, and preserves LIST interoperability across existing model readers.
Are these changes tested?
The affected Maven suites for FINITE_VECTOR schemas, writing, reading, adapters, and filtered reads passed, and Spotless passed for all touched modules.
Closes #3877