Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the docs part of #9078. The design questions there (signalling the drop back to the spout, dead-lettering) are left alone.
What is the purpose of the change
docs/storm-kafka-client.mdsays nothing about what happens when a tuple from the Kafka spout is never acked, for example because it always fails to deserialize on the receiving worker. In at-least-once mode that quietly stops commits for the partition and lag keeps climbing, and with the default retry settings it never recovers.I added a short "Records that are never acked" section that explains:
max.uncommitted.offsets)DEFAULT_MAX_RETRIESisInteger.MAX_VALUE)KafkaSpoutRetryExponentialBackoffwith a finitemaxRetries, plusKafkaTupleListener.onMaxRetryReachedto log or keep track of the record before the spout acks itmaxRetriesalso gives up on tuples that fail for temporary reasonsDocs only; no code changes.
How was the change tested
I checked the description against
KafkaSpout.fail,KafkaSpoutConfig(defaults and builder methods) andKafkaTupleListeneron master, and that the example uses the actual constructor and method names. I also read the rendered Markdown.Happy to adjust the wording or move it somewhere else in the doc if you'd prefer.
An AI assistant helped draft this change; I reviewed it and take responsibility for it.