Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7724 (STORM-3942).
What is the purpose of the change
The binary distribution in
storm-dist/binary/final-packagecopies files that other modules build: thelib-*directories from the*-binsiblings, and the UI files fromstorm-webapp/target/classes/WEB-INF. maven-assembly-plugin silently skips a fileSet whose directory doesn't exist, so if one of those wasn't built you still get BUILD SUCCESS and a tarball that is missing pieces.For example, on master, running
mvn packageinstorm-dist/binary/final-packagealone (the*-binmodules not built) succeeds, and the tarball has nolib-webapp,lib-common,lib-autocreds, submit-tools or kafka-monitor jars.I added a
maven-enforcer-pluginrequireFilesExistexecution to final-package, bound toprepare-package(right before those files are used). It checks the five siblinglib-*directories plusstorm-webapp/target/classes/WEB-INF/index.htmlandWEB-INF/dist, and fails with the list of missing paths and a short hint on how to build them.Two notes:
${maven.multiModuleProjectDirectory}instead of${project.basedir}/../.., becauserequireFilesExistcompares each path with its canonical form and treats anything with..as missing. The root pom already uses that property for the rewrite and checkstyle scripts.storm-dist/source. Its assembly only reads the source tree (the repo root and two READMEs underexternal/), nothing that a build produces, so I couldn't find a file there that can be missing in a normal checkout. Happy to add checks there too if you had something specific in mind.Happy to adjust if you'd prefer a different approach (for example checking more of the files in common.xml, or a different phase).
How was the change tested
Locally with JDK 25 and Maven 3.9.11, after installing storm-core, storm-webapp, storm-submit-tools, storm-autocreds and storm-kafka-monitor:
mvn package -f storm-dist/binary/pom.xml -Dgpg.skip -DskipTests(same as the nightlies job): the rule passes and both tarballs are builtstorm-webapp/target/classes/WEB-INF/distmoved away,mvn packageinstorm-dist/binaryfails and names that pathmvn cleanonstorm-dist/binary,mvn packageinfinal-packagealone fails and lists the five missinglib-*directories (on master the same command succeeds with the incomplete tarball described above)I didn't run the full
-Pdistrelease build.An AI assistant helped draft this change; I reviewed it and take responsibility for it.