Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Follow-up to #1358. A directConnectPath of
""is a valid root endpoint, but was treated as missing. Preserve it for both capability formats, including when an empty prefixed path overrides a legacy path.Reuse the existing command executor instead of invoking its constructor again. This preserves subclasses with required constructor arguments, instance state, and registered commands. Copy the client config so the caller's configuration remains unchanged; clear the old HTTP pool, reevaluate proxy selection for the new endpoint, and rebuild the pool when keep-alive is enabled. Read the effective config directly from the executor.
Regression coverage includes root paths, prefixed precedence, custom executor state and commands, both keep-alive settings, and proxy selection/pool cleanup. The root-path and custom-constructor regressions fail on #1358's original implementation.
Validation
ruff check .,ruff format --check ., andmypy appiumpassed.Types of changes