Repository navigation
Add fish completions wrapper - #737
Merged
DannyBen merged 3 commits intoNov 10, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
|
Thanks for the contribution! This fits well with the existing completion adapters and tests. Could you address these two small items?
The schema validation failure appears unrelated; it failed during dependency installation. Once these are addressed, we can take over any remaining adjustments and finalize the PR. |
Member
|
Let me know when it is ready to merge. Ignore the JSON schema CI failure, I will deal with it later. |
Contributor
Author
|
I think this PR is done, I have tested the completions myself with fish 4.7.1. Thanks for your guidance. |
Member
|
Thanks for this. It will be a part of 2.0.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
fishas a third runtime completion shell alongsidebashandzsh, generating asend_completions_fishadapter loadable withcli completions fish | source.