Skip to content

Add fish completions wrapper - #737

Merged
DannyBen merged 3 commits into
bashly-framework:masterfrom
alexandre-dos-reis:add/fish-completion
Nov 10, 2026
Merged

DannyBen merged 3 commits into
bashly-framework:masterfrom
alexandre-dos-reis:add/fish-completion

Conversation

@alexandre-dos-reis

@alexandre-dos-reis alexandre-dos-reis commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Adds fish as a third runtime completion shell alongside bash and zsh, generating a send_completions_fish adapter loadable with cli completions fish | source.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@DannyBen

DannyBen commented Nov 9, 2026

Copy link
Copy Markdown
Member

Thanks for the contribution! This fits well with the existing completion adapters and tests. Could you address these two small items?

  • Add fish alongside zsh in the CI test workflow.
  • Fix the ShellCheck SC2028 warning by adjusting the output statement—for example, using printf '%s\n' instead of echo—rather than suppressing the warning.

The schema validation failure appears unrelated; it failed during dependency installation.

Once these are addressed, we can take over any remaining adjustments and finalize the PR.

@DannyBen

DannyBen commented Nov 9, 2026

Copy link
Copy Markdown
Member

Let me know when it is ready to merge. Ignore the JSON schema CI failure, I will deal with it later.

@alexandre-dos-reis

Copy link
Copy Markdown
Contributor Author

I think this PR is done, I have tested the completions myself with fish 4.7.1.

Thanks for your guidance.

@DannyBen DannyBen added this to the 2.0.1 milestone Nov 10, 2026
@DannyBen
DannyBen merged commit ebfdc96 into bashly-framework:master Nov 10, 2026
8 of 10 checks passed
@DannyBen

Copy link
Copy Markdown
Member

Thanks for this. It will be a part of 2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants