Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #62: avoid a repeated SAS emoji confirmation when a server response still advertises the already-used
sas.confirmaction.Changes
sas.confirmtwice for the same ID in one CLI run.verification_action_not_availableanddetails.state: "done"as a completed action, then re-read readiness. Other 409s still fail normally.needs-first-syncorready, instead of creating a new verification request.Validation
bun run --cwd packages/cli build— passed.bun run --cwd packages/cli typecheck— passed.bun test packages/cli/test/*.test.ts— 53 passed, 0 failed.The tests contain synthetic data only; no account tokens, keys, or private messages.
Scope
This is a CLI-only fix, without indefinite polling. PR #66 separately repairs the SDK resource names and may need to land first.