Repository navigation
fix(jobscheduler): drop jobs already waiting in the same queue - #451
Merged
Merged
Conversation
joshfriend
requested review from
stuartwdouglas
and removed request for
a team
November 16, 2026 20:30
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca72a6aa60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Stale ref checks submit a fetch per request, and the fetch queue runs them one at a time, so busy repos piled up hundreds of identical fetches.
joshfriend
force-pushed
the
jfriend/dedupe-scheduler-queue
branch
from
November 16, 2026 20:33
ca72a6a to
9448fb0
Compare
luispadron
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every ref request that finds a mirror stale submits a fetch, and fetches for a repo run one at a time. During work hours busy repos like cash-server get requests faster than a fetch finishes, so production pods built up hundreds of identical queued fetches that only drained overnight.
The scheduler now drops a job when one with the same queue and id is already waiting, so each repo has at most one running and one waiting copy. TrySubmit treats a waiting duplicate as accepted.