Repository navigation
withstack: support Unwrap() []error for multi-errors - #170
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Errors returned by errors.Join wrap the inner joined error with
withstack.WithStackDepth. Previously, withStack only implemented
Unwrap() error, causing panics when callers type asserted to
interface{ Unwrap() []error } to inspect joined errors in Go 1.20+.
Add withStackMulti which implements Unwrap() []error when the wrapped
cause provides Unwrap() []error, while preserving Cause() error,
SafeFormatError, Format, and SafeDetails. Update formatRecursive
and visitAllMulti recursion branching to avoid duplicate traversal.
Fixes cockroachdb#162
Signed-off-by: AdamMagued <adamismailmageud@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #162
withstack.WithStackDepth: ReturnwithStackMultiwhen wrapped cause implementsinterface{ Unwrap() []error }withstack.withStackMulti: ProvideUnwrap() []error,Cause() error,Error() string,SafeFormatError,Format, andSafeDetailswithstack.GetReportableStackTrace,withstack.GetOneLineSource: RecognizeourWithStackMultiNametype keyerrbase.formatRecursive: Branch causal recursion to unwrap slice errors only when single unwrap yields nilreport.visitAllMulti: Branch child error recursion to prevent duplicate traversal on multi-error wrapperswithstack/withstack_test.go: Add tests coveringwithStackMultislice unwrapping, stack capture, safe details, and single-error unwrappingerrutil_api_test.go: Add tests verifyingerrors.Joinreturns errors implementinginterface{ Unwrap() []error }, witherrors.Isanderrors.AssupportTest Plan
go test ./...in container sandbox passes cleanlygo mod tidyverified cleanerrors.Joinslice unwrap type assertion verified without panicslmk if you need any adjustments
This change is