Repository navigation
Conversation
…nHTTP crash - setParameter[key=] read past its argument list; it now sets an empty value. - listenHTTP read one segment per request, so a POST body sent after the headers got a 404. It now reads the whole request, with a size cap and a receive timeout. - pyforefire's execute() left the kernel writing to a stream freed on return, so a listenHTTP server started from Python crashed on its first command.
Loads a synthetic tile from Python, restores checkpoints in fresh workers for both arrival-map layouts, and drives a tile case over listenHTTP by GET and POST. Run in CI by invariants.yml.
… too Command::OutputCapture points command output at a caller's stream and back to cout when it goes out of scope. The Java and WASM bindings left it on a stream freed on return, as pyforefire did; all three now use the guard.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests the Python bindings and listen mode on
.fftile/.ffstate, as asked in #282. Both work; testing turned up three older bugs, fixed here:setParameters[ForeFireDataDirectory=]segfaulted (empty value read past the argument list).tests/ffstate/smoke.pyuses that line, so it crashed on Linux.listenHTTPread one segment per request: a POST whose body comes after the headers got a 404 (every POST from Python'surllib).listenHTTPserver started from pyforefire crashed on its first command:execute()left the kernel writing to a freed stream. Java and WASM bindings had the same pattern; all three now use one scoped guard,Command::OutputCapture.New:
tests/python/test_fftile_ffstate.pyandtest_listen.py, on a small synthetic tile, ininvariants.yml. They fail on dev, one check per bug.Tested: both new tests, Java binding compiled against JDK 21 (WASM left to CI, no emcc here), CTest,
test_runner/test_ensemble/test_moisture_invariants, andtests/ffstate/smoke.py(synthetic tile). Not tested: Meso-NHmode=attach, real Corsica tiles.Drafted with Claude Opus 5.5, reviewed by a human before posting.