Repository navigation
fix(deps): override node-forge to 1.4.3 and bump vitest to 4.1.12 - #89
Conversation
Clears the open node-forge alerts (pulled in by the playground's Expo CLI) and the @vitest/mocker alerts. Neither package ships in @formbricks/react-native. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
No actionable comments were generated in the recent review. WalkthroughThe root package manifest adds a pnpm override that pins Merge Risk:
|



Summary
Clears the Dependabot alerts on this repo that have an upstream fix. Oneleet flagged the open high-severity
node-forgealert (#145, GHSA-86w9-cpqp-85rv) as past its SLA on 11 Nov.None of these packages ship in
@formbricks/react-native. The published SDK's only runtime dependencies are@react-native-community/netinfoandzod@4.6.6, which is already patched. Every alert is in dev tooling: the playground's Expo CLI or the Vitest test runner. SDK consumers are not affected, so no SDK release is needed.Fixed
node-forge1.4.0 → 1.4.3 via a pnpm override. It comes in throughexpo > @expo/cliand@expo/code-signing-certificates, which pin^1.3.3/^1.2.1, so 1.4.3 is in range. This closes 11 alerts (5 high, 3 medium, 3 low): #145 and #163–#173. GHSA-86w9 lists no patched version, but its range is<= 1.4.0, so 1.4.3 is outside it. 1.4.3 also covers the four advisories fixed in 1.4.3 that Dependabot raised on formbricks/formbricks today.vitestand@vitest/coverage-v84.1.11 → 4.1.12. This pulls in@vitest/mocker4.1.12 and closes #154 and #159 (medium).Not fixable in this PR
zod3.25.76 (high, GHSA-mrhx-c7xc-m3w5, #161). It comes in throughexpo > @expo/cli55.x, which depends onzod@^3.25.76. No 3.x release is patched, since the fix is 4.6.6 only. Overriding it to v4 would change the API under the Expo CLI. Newer@expo/cli(SDK 58) drops zod entirely, but that is a playground Expo SDK upgrade with code changes. The vulnerable path is the CLI validating local config, which an attacker can't reach.deepmerge4.3.1 (low, GHSA-gcqx-w48m-w2h4, #162). It comes in through@expo/config, and no patched release exists upstream.Both remaining alerts are dev-only and need a dismissal with a reason, or the Expo SDK upgrade.
Test plan
Ran locally:
pnpm install: the lockfile diff only touchesnode-forgeand thevitest/@vitest/*packages, and dedupes two stale entries (@babel/helper-string-parser@7.29.7,picomatch@4.0.4).pnpm lintpnpm check-typespnpm test: 23 files, 225 tests passed on Vitest 4.1.12pnpm build@expo/code-signing-certificates. It generates a key pair and a self-signed code-signing certificate, round-trips the PEM, validates the certificate, signs and verifies with RSA-SHA256, and issues a development certificate from a CSR that verifies against the root. All steps passed.pnpm audit: 27 → 4 advisories. The 4 left arezodanddeepmergeabove, plusglob13.0.4 andminimatch10.2.3 (moderate), which Dependabot hasn't raised yet. Those two need major-version overrides under Expo tooling, so they are out of scope here.Not verified: playground iOS/Android bundles. The override doesn't touch Metro, and Expo only loads node-forge for code signing.