Skip to content

Fix additive packs for the selected language - #4314

Open
theinfosecguy wants to merge 1 commit into
github:mainfrom
theinfosecguy:fix-pack-language-merge
Open

theinfosecguy wants to merge 1 commit into
github:mainfrom
theinfosecguy:fix-pack-language-merge

Conversation

@theinfosecguy

Copy link
Copy Markdown

Merge +packs into the job’s selected language instead of the first key in a shared config. This prevents added queries from being silently skipped. Includes regression tests.

Verified with 1,232 tests and CodeQL 2.20.7/2.27.4 runs. The bundled command-injection repro on 2.27.4 reports 0 findings before the fix and 1 afterward.

@theinfosecguy
theinfosecguy requested a review from a team as a code owner November 11, 2026 11:40
Copilot AI auto review requested due to automatic review settings November 11, 2026 11:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the fix that applies additive query packs to the job’s selected language.

No open issues 🎉

What changed in this PR

Fixes CodeQL Action’s additive packs handling so extra query packs apply to the job’s selected language, rather than the first language in a shared configuration.

Changes:

  • Passes selected languages into configuration generation and handles missing language entries.
  • Adds regression coverage for shared configurations, key ordering, and array-form packs.
  • Updates the generated bundle and adds a release note.
File Description
unreleased-change-notes/​fix-pack-language-merge.md Documents the additive packs fix.
tests/​multi-language-repo/​.github/​codeql/​codeql-config-packaging3.yml Adds Ruby packs before JavaScript to exercise language selection.
src/​config/​db-config.ts Merges additive packs into the selected language’s entry.
src/​config-utils.ts Passes selected languages to configuration generation.
src/​config-utils.test.ts Tests shared-config merging through initialization.
src/​codeql.test.ts Covers key ordering, missing or empty entries, and array-form packs.
lib/​entry-points.js Updates the generated JavaScript bundle.

Review effort: Balanced (auto)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants