Repository navigation
Unified: Extract Swift some or any type - #23057
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89a32053-c825-435d-bc04-d901b469ccfa
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review identifies no active issues with the added Swift some and any type support.
No open issues 🎉
What changed in this PR
Adds support for Swift some and any types in the unified extractor, preserving their modifiers and underlying constraints instead of emitting unsupported nodes.
Changes:
- Translates both type forms into
modified_type_exprnodes. - Adds corpus tests and expected output for
someparameters and return types, and ananyvariable type.
| File | Description |
|---|---|
unified/extractor/tests/corpus/swift/types/some-type.swift |
Tests some parameter and return types. |
unified/extractor/tests/corpus/swift/types/some-type.output |
Records expected parsing and extraction for some. |
unified/extractor/tests/corpus/swift/types/any-type.swift |
Tests an any variable type. |
unified/extractor/tests/corpus/swift/types/any-type.output |
Records expected parsing and extraction for any. |
unified/extractor/src/languages/swift/swift.rs |
Adds structured translation for someOrAnyType and removes its unsupported fallback. |
Review effort: Balanced (auto)
Contributor
|
Changes look reasonable to me.
|
Contributor
Author
|
I've update the tests and started a DCA run: https://github.com/github/codeql-dca-main/issues/40571 |
Contributor
Author
|
DCA seems fine. |
asgerf
previously approved these changes
Nov 11, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a0ac853-3f88-4fe6-92d3-62af531b7753
Contributor
Author
|
Needs re-approval after merging |
asgerf
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.