Skip to content

modelgenerator: default to generating JSON #23097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickrolfe wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

modelgenerator: default to generating JSON #23097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion misc/scripts/models-as-data/bulk_generate_mad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ def main(config, args) -> None:
parser.add_argument(
"--extension-format",
choices=["json", "yaml"],
default="yaml",
default="json",
help="Format for the generated data extension files (default %(default)s)",
)
args = parser.parse_args()
Expand Down
4 changes: 2 additions & 2 deletions misc/scripts/models-as-data/convert_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ def __init__(self, language, dbDir):
)
self.extDir = os.path.join(self.codeQlRoot, f"{self.language}/ql/lib/ext/")
self.dirname = "modelconverter"
# N.B. change this to .model.json to change the output format:
self.modelFileExtension = ".model.yml"
# N.B. change this to .model.yml to change the output format:
self.modelFileExtension = ".model.json"
self.workDir = tempfile.mkdtemp()

def runQuery(self, query):
Expand Down
4 changes: 2 additions & 2 deletions misc/scripts/models-as-data/generate_mad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class Generator:
threads = 0
folder = ""
single_file = None
extension_format = "yaml"
extension_format = "json"

def __init__(self, language=None):
self.language = language
Expand Down Expand Up @@ -123,7 +123,7 @@ def make():
p.add_argument(
"--extension-format",
choices=["json", "yaml"],
default="yaml",
default="json",
help="Format for the generated data extension files (default %(default)s)",
)
generator = p.parse_args(namespace=Generator())
Expand Down
Loading