Repository navigation
Add Toaster to the Music collection - #5459
Open
StopBanning wants to merge 1 commit into
Open
StopBanning wants to merge 1 commit into
StopBanning wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The collection entry is explicitly self-promotional and conflicts with CONTRIBUTING.md’s guidance to avoid conflicts of interest and likely reject self-promotion, so it should be removed.
1 open issue
What changed in this PR
Adds the author's StopBanning/toaster repository to the existing Music collection, but the self-promotional addition conflicts with the repository's contributing guidelines.
Changes:
- Appends
StopBanning/toasterto the collection's YAML item list. - Requests removal of the entry because it is self-promotion.
| File | Description |
|---|---|
| collections/music/index.md | Adds the StopBanning/toaster repository to the Music collection's YAML item list. |
Review effort: Lite (dynamic)
| - schismtracker/schismtracker | ||
| - chunkypixel/TIATracker | ||
| - milkytracker/MilkyTracker | ||
| - StopBanning/toaster |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Please confirm this pull request meets the following requirements:
Heads up: I made Toaster, so I've left that second box unticked. This is the follow-up to #5431, with the template this time like you asked.
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png, square, dimensions 288x288, size <= 75 kB)index.md)Toaster listens to whatever song is playing and writes it out as Strudel code you can actually play with, with visuals that move to it. It's free and open source, in the browser or as a Windows/Mac app. Figured it fits next to Sonic Pi and Orca.
Since the first PR it's picked up 140 stars and 320 app downloads, and it's on awesome-strudel. Totally get it if being the author rules it out. Thanks for taking a look either way!