Repository navigation
Wrap the Verification panel at spaces and operators, one conjunct per line - #189
CatarinaGamboa wants to merge 3 commits into
Conversation
… line Expected and every Found line now show one top-level conjunct per line, and a conditional's condition and branches each on a line of their own, with a hanging indent for wrapped lines. The VC cells no longer break anywhere, so a name is split only when it alone is wider than the line. A narrow panel puts each binder above its predicate, with tighter padding and line height. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Clean-code reviewI audited this diff with the clean-code-principles checklist. Fixed
Declined
|
…erals Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex review, round 1
Fixed (both)
Tests: 127 unit, typecheck, lint, and 39 server tests pass. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex review, round 2
Fixed. A changed predicate is now split into lines on both sides. The old and new lines are paired with the same Tests: 127 unit, typecheck, lint, and 39 server tests pass. |
Codex review, round 3
The loop ends here: nothing to fix. |
Closes #187
What changes
The Verification panel's Expected box and every Found line:
&&at the end of each line except the last. An&&inside parentheses or a string literal stays on its line. Nothing is split when a weaker operator (||,-->,?:) sits outside the parentheses, so a line never looks like a conjunct of the whole expression.? …,: …). This is what makes A1_09 fit.overflow-wrap: anywhere, which gavefailures.siz|e(),compressionN|otExplicitanddisplay(host|) ==. They now usebreak-word, so a line breaks at a space and splits a name only when the name alone is wider than the line.∀host) goes above its predicate, so the predicate gets the whole width. The card and the Found box get less horizontal padding, and the Found lines get line-height 1.4 instead of 1.6.This is display only. The text of every expression is the same as before, only laid out on more lines. The hover and the CLI do not change.
Acceptance check: the six study tasks at the study width
Headless VS Code at 1600×900, Dark Modern, default side bar (300 px; the error card is about 240 px). Verifier 0.0.37, the released one, which is what this branch builds with. Each image shows main on the left and this PR on the right. The webview is 794 px tall. "Found ends at" is the bottom of the Found box, in webview px.
Expected and Found are fully visible in all six, with no name broken.
Verifier version
None needed. This works with 0.0.37 and with main.
Overlap with open PRs
vc-changes.ts(formatImplicationLines, with its ownsplitConjuncts), and this PR changesrenderVCLinein the same file.&&, so a line List Found as facts and show only readable simplification steps #185 has already split is left as it is.splitConjuncts. This PR's copy is inhighlighting.tsand follows the same rules.sections.ts.Not changed
E_OSS_A1_01_SlideRecode|r.java) still break anywhere. They are in a<pre>withbreak-word, and the names are wider than the card. This was outside the issue.||(A1_01's Expected) is not split into lines. The issue asks for conjuncts.Checks
npm run test:unit(127 passed; 3 new tests, each fails on main),npm run test:typecheck,npm run lint, servermvn -B test(39 passed, unchanged).🤖 Generated with Claude Code