Repository navigation
Strip content mapper known extensions as part of moduleSuffixes lookups - #65417
Open
Andrew Branch (andrewbranch) wants to merge 1 commit into
Open
Andrew Branch (andrewbranch) wants to merge 1 commit into
Andrew Branch (andrewbranch) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
Author: Team
For Milestone Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change to module-suffix handling of content-mapper extensions.
No open issues 🎉
What changed in this PR
Fixes #64548 by making the native compiler insert moduleSuffixes before registered content-mapper extensions, so card.box correctly probes card.web.box rather than card.box.web.
Changes:
- Recognizes the longest registered extension when no built-in extension matches.
- Adds regression coverage for compound extensions, fallback resolution, built-in extensions, and unchanged extensionless-import behavior.
- Adds resolution, diagnostic, and content-mapper baselines.
| File | Description |
|---|---|
tsc/testdata/tests/cases/compiler/contentMapperModuleSuffixes.ts |
Adds module-suffix regression cases. |
tsc/testdata/baselines/reference/compiler/contentMapperModuleSuffixes.trace.json |
Records expected file probes and resolution results. |
tsc/testdata/baselines/reference/compiler/contentMapperModuleSuffixes.errors.txt |
Records the expected unresolved extensionless import. |
tsc/testdata/baselines/reference/compiler/contentMapperModuleSuffixes.contentmapper |
Records mapped platform variants and fallback content. |
tsc/internal/module/resolver.go |
Recognizes mapper extensions before inserting module suffixes. |
Review effort: Balanced
|
|
||
| ext := tspath.RootedFilePathFromPath(fileName.path).Extension() | ||
| if ext == "" && len(r.resolver.extraExtensions) > 0 { | ||
| ext = tspath.RootedFilePathFromPath(fileName.path).LongestExtension(r.resolver.extraExtensions, tspath.CaseSensitive) |
Member
Author
There was a problem hiding this comment.
Note that recognition of built-in file extensions is also case-sensitive in most places throughout the compiler.
Jake Bailey (jakebailey)
approved these changes
Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64548 and partly #65047 (comment)