Repository navigation
Conversation
Signed-off-by: Christopher Krah <48338417+chrikrah@users.noreply.github.com>
…rics parser Signed-off-by: Christopher Krah <48338417+chrikrah@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@csmarchbanks, a small parser fix.
_parse_timestamp()splits-0.5at the dot and callsint("-0"), which gives0, so a timestamp between -1 and 0 parses as +0.5. The spec allows negative timestamps, and since #1229 the library writes this exact value (tests/test_samples.py:19expects-0.500000000). Exemplar timestamps take the same path.The fix builds that case as
Timestamp(-0.5, 500000000), the form the samples test already uses. The new test parses one sample at-0.500000000and one exemplar at-0.250000000, next to a-1.5control.No issue exists for this; it follows #1229. I kept the fix in the parser and left
Timestampalone, because its constructor is public and the writer side already works. Does that split work for you?