Skip to content

ci: Use PyPy 3.11 - #1456

Open
tomasr8 wants to merge 4 commits into
python-babel:masterfrom
tomasr8:pypy311
Open

tomasr8 wants to merge 4 commits into
python-babel:masterfrom
tomasr8:pypy311

Conversation

@tomasr8

@tomasr8 tomasr8 commented Nov 10, 2026

Copy link
Copy Markdown
Member

Release 7.3.19 in February 2025 was the last release to include PyPy 3.10. Following releases dropped it in favour of PyPy 3.11. Let's use that one.

This PR also fixes one xfail test on PyPy.

Some doctests, like `core.default_locale` modify os.environ,
including setting a different locale, without proper cleanup.

When a PyPy subprocess spawned by `test_setuptools_commands`
tries to set the non-existent locale, it crashes which
makes the test fail.

This PR adds a cleanup fixture that restores os.environ after
every test.
@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.67%. Comparing base (cb0c7a7) to head (c0a0f62).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1456   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          27       27           
  Lines        4983     4983           
=======================================
  Hits         4668     4668           
  Misses        315      315           
Flag Coverage Δ
macos-15-3.10 ?
macos-15-3.12 ?
macos-15-3.13 ?
macos-15-3.15 ?
macos-15-3.9 ?
macos-15-pypy3.10 ?
macos-26-3.10 92.75% <ø> (?)
macos-26-3.15 92.93% <ø> (?)
macos-26-3.9 92.69% <ø> (?)
ubuntu-24.04-3.10 92.77% <ø> (ø)
ubuntu-24.04-3.11 92.71% <ø> (ø)
ubuntu-24.04-3.12 92.97% <ø> (ø)
ubuntu-24.04-3.13 92.97% <ø> (ø)
ubuntu-24.04-3.14 92.95% <ø> (ø)
ubuntu-24.04-3.15 92.95% <ø> (ø)
ubuntu-24.04-3.9 92.71% <ø> (ø)
ubuntu-24.04-pypy3.10 ?
windows-2022-3.10 ?
windows-2022-3.11 ?
windows-2022-3.12 ?
windows-2022-3.13 ?
windows-2022-3.14 ?
windows-2022-3.15 ?
windows-2022-3.9 ?
windows-2022-pypy3.10 ?
windows-2025-3.10 92.76% <ø> (?)
windows-2025-3.11 92.70% <ø> (?)
windows-2025-3.14 92.94% <ø> (?)
windows-2025-3.9 92.70% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 88 untouched benchmarks


Comparing tomasr8:pypy311 (c0a0f62) with master (3072a70)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (19d490d) during the generation of this report, so 3072a70 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Comment thread conftest.py Resolved
Comment thread .github/workflows/ci.yml Resolved
tomasr8 and others added 2 commits November 12, 2026 20:37
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@tomasr8

tomasr8 commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

This is not the first time the CI fails for PyPy on Windows (another run: https://github.com/python-babel/babel/actions/runs/43040240030/job/130589759461) though it fails in different steps and the error is not very helpful either..

It seems like it started happening after the Windows runner update to 2025 so it's probably related.

@tomasr8

tomasr8 commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

Hmm maybe it's not because of the runner update. There seems to some issue w/ PyPy on Windows and the latest version of pip: pypa/pip#14431

@tomasr8

tomasr8 commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

Opened #1462 to try to fix it

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants