Skip to content

Update tox envs + switch to dependency groups - #1464

Draft
tomasr8 wants to merge 2 commits into
python-babel:masterfrom
tomasr8:tox
Draft

tomasr8 wants to merge 2 commits into
python-babel:masterfrom
tomasr8:tox

Conversation

@tomasr8

@tomasr8 tomasr8 commented Nov 13, 2026

Copy link
Copy Markdown
Member

I originally just wanted to remove the py38 env from tox but then (as it usually happens 😆 ) I noticed the pytz, jinja and setuptools envs. They all install the same dev extra meaning we run the same test suite multiple times, one for each env.

The envs actually used to install the respective packages (pytz, jinja and setuptools ) until #1159 which removed it. I don't think we need to fully restore this behaviour, probably one env with the optional dependencies and one without is enough, which is what I've done here.

I also took the liberty to switch to dependency groups since there was the TODO in pyproject.toml and it just felt natural here. There are now two groups:

  • test: installs only what is needed for the tests
  • dev: installs the extras (pytz, etc..)

Tox runs the dev group on all versions + runs the bare test group on py314 only.

Feedback welcome! :)

@codspeed

codspeed Bot commented Nov 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 88 untouched benchmarks


Comparing tomasr8:tox (3663f96) with master (3072a70)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (19d490d) during the generation of this report, so 3072a70 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant