Repository navigation
Fix equality check to handle TypeError - #216
Open
Affanasrar wants to merge 1 commit into
Open
Affanasrar wants to merge 1 commit into
Affanasrar wants to merge 1 commit into
Conversation
Handle TypeError in equality comparison.
agammann
reviewed
Nov 8, 2026
agammann
left a comment
agammann
left a comment
There was a problem hiding this comment.
The added try/except block is misindented: try is indented beyond the method body and except does not align with it. This makes _headers.py fail to import before the equality fix can run. Could you align the block and add a regression test for comparing Headers with a non-iterable operand?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #214
Root Cause
Headers.eq called list(other) directly without handling non-iterable types. When comparing against a non-iterable operand (such as None or unittest.mock.ANY), list(other) raised TypeError instead of returning NotImplemented to allow Python's equality fallback.
Fix
Wrapped the list comparison in a try-except TypeError block in Headers.eq to return NotImplemented when other is non-iterable.