Repository navigation
Conversation
Open the group popup with the matched feature as its source, without leaving a duplicate feature binding. Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1286.
GeoJsonPopupbinds its popup to the GeoJSON group. The Search callback only checks the matched feature's_popup, so it never opens a group-bound popup.When the feature has no popup of its own, temporarily bind the group's popup to that feature, open it, and remove the temporary binding. This gives the popup content callback the matched feature without leaving duplicate click handlers behind. Existing feature-bound popups keep their current path.
Added a generated-JavaScript regression test, confirmed failing before the fix and passing afterward.
Verification
pytest tests/plugins/test_search.py -q: 1 passed.pytest tests --ignore=tests/snapshots --ignore=tests/selenium --ignore=tests/playwright -q: 396 passed, 4 failed. The same four tests fail on unmodified upstream: missinggeodatasetsand three PNG-rendering tests requiring Selenium. No new suite failures.ruff checkandgit diff --check: passed.🤖 Generated with Claude Code