Repository navigation
Conversation
Combine multiple child nodes before setting popup content so later children do not overwrite earlier ones. Load lazy children together while keeping single-child markup unchanged. Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1245.
Popupcurrently callssetContent()for every HTML child. Each call replaces the previous content, so only the last child survives. This also removes the earlier chart containers when multiple Vega elements are added to a popup.For multiple children, append their DOM nodes to one container and set the popup content once. Keep the existing single-child markup and child variables used by chart initialization. For lazy popups, load all children together in one click callback. Empty child output is ignored.
Added eager/lazy regression tests; both fail before the fix and pass afterward. An inverted multi-child condition also makes both tests fail.
Verification
pytest tests/test_map.py -q: 23 passed, including the new eager/lazy cases and the existing single-child rendering checks.Second; the fix retainsFirstandSecondthrough loading and reopening in both modes, including an empty child. This checks popup DOM behavior, not Vega chart drawing or the Selenium suite.geodatasetsand Selenium-dependent PNG failures verified on unmodified upstream earlier in this run.ruff checkandgit diff --check: passed.🤖 Generated with Claude Code