Repository navigation
gh-161730: Fix the mode in the compression.zstd.open() invalid mode error - #161731
Open
andresdelfino wants to merge 1 commit into
Open
andresdelfino wants to merge 1 commit into
andresdelfino wants to merge 1 commit into
Conversation
…mode error compression.zstd.open() removed 't' from the mode before checking for the invalid 't' and 'b' combination, so the error message named the modified mode (e.g. "Invalid mode: 'rb'" for 'rtb'), which is a valid mode the caller didn't pass. Check before removing 't', matching gzip.open(), bz2.open() and lzma.open(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compression.zstd.open()removed't'from the mode before checking for the invalid't'and'b'combination, and formatted the error message with the modified string. For'rtb'the message wasInvalid mode: 'rb', which names a valid mode the caller didn't pass. This moves themode.replace('t', '')call after the check, so the message shows the mode as passed (Invalid mode: 'rtb'), likegzip.open(),bz2.open()andlzma.open().🤖 Generated with Claude Code
compression.zstd.open()names the wrong mode in its invalid mode error #161730