Repository navigation
Fix "Table Footer Should Contain" for <th> cells - #2000
Open
b-vamsipunnam wants to merge 3 commits into
Open
b-vamsipunnam wants to merge 3 commits into
b-vamsipunnam wants to merge 3 commits into
Conversation
emanlove
approved these changes
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
Table Footer Should Containto find text in both<td>and<th>cells inside<tfoot>.Motivation
A table footer can use a
<th>cell for a label like “Total.” The keyword currently searches only<td>cells, so it fails even when the expected text is present.Implementation
I updated the footer locator and keyword documentation. I also added an HTML fixture with
<th>cells in the header, body, and footer so the tests can verify that only footer text matches.Tests
The five new acceptance tests cover both footer cell types and verify that text in the header, body, or another table’s footer does not match. The footer
<th>test failed before the fix and passed afterward.git diff --checkpassed.Files Changed
src/SeleniumLibrary/keywords/tableelement.pyatest/acceptance/keywords/tables/footer_should_contain.robotatest/resources/html/tables/tables.htmlRelated Issues
Fixes #1436.
Request
If appropriate, could you add the
acknowledgelabel to #1436? Thank you!