Repository navigation
ci: include native bindings and docs in package previews - #626
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
6bb776f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c3b42442.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-fix-package-previ.rstack-cli.pages.dev |
create-rstack
rstack
@rstackjs/cli-darwin-arm64
@rstackjs/cli-darwin-x64
@rstackjs/cli-linux-arm64-gnu
@rstackjs/cli-linux-arm64-musl
@rstackjs/cli-linux-ppc64-gnu
@rstackjs/cli-linux-riscv64-gnu
@rstackjs/cli-linux-riscv64-musl
@rstackjs/cli-linux-s390x-gnu
@rstackjs/cli-linux-x64-gnu
@rstackjs/cli-linux-x64-musl
@rstackjs/cli-win32-arm64-msvc
@rstackjs/cli-win32-ia32-msvc
@rstackjs/cli-win32-x64-msvc
commit: |
chenjiahan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The previews introduced in #370 omit the native bindings required by
rs fmtand the bundled documentation. ReviewChanges
Reuse the release workflow to assemble native packages and stage documentation, then publish both JavaScript packages and all native packages together so the CLI resolves the matching preview bindings.
Publish previews only on manual dispatch for the selected ref, and cancel superseded runs for that ref. Remove the workflow text assertions.