Skip to content

kerberos/ntlm: check sequence numbers - #5291

Merged
gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:krb-ntlm-seq
Nov 12, 2026
Merged

gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:krb-ntlm-seq

Conversation

@gpotter2

Copy link
Copy Markdown
Member
  • properly check sequence numbers in Kerberos & NTLM

AI-Assisted: yes (Codex GPT-6.1-Sol)
assert passiveContext.ssp_context.passive

= GSS_Accept_sec_context rejects a replayed AP-REQ
= GSS_Accept_sec_context rejects a replayed AP-REQ without the replay flag

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
= GSS_Accept_sec_context rejects a replayed AP-REQ without the replay flag
= GSS_Accept_sec_context rejects a replayed AP-REQ

Comment thread scapy/layers/kerberos.py
return Context, err, gssErrorCode

# Store the time for future detections
# Cache authenticators to avoid replay

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Cache authenticators to avoid replay
# Store the time for future detections

@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.15%. Comparing base (4a0c880) to head (9326031).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/kerberos.py 70.00% 6 Missing ⚠️
scapy/layers/ntlm.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5291      +/-   ##
==========================================
- Coverage   80.66%   80.15%   -0.52%     
==========================================
  Files         375      375              
  Lines       98750    98766      +16     
==========================================
- Hits        79661    79169     -492     
- Misses      19089    19597     +508     
Files with missing lines Coverage Δ
scapy/layers/ntlm.py 80.54% <60.00%> (-0.17%) ⬇️
scapy/layers/kerberos.py 72.18% <70.00%> (+0.01%) ⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2
gpotter2 merged commit b961379 into secdev:master Nov 12, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant