Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 3272eff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #726.
When a query failed, hitting Retry in an
<Errored>fallback could read the same rejected promise from the router cache. The fallback stayed visible and the query did not run again.A rejected client entry remains available while Solid claims the server-rendered fallback. Outside hydration, the next read can fetch again immediately. Concurrent reads still share their in-flight request, and an older rejected request leaves a newer cache value intact.
Verified the failing retry against the published
2.0.0-next.44package. Added regressions for clicking Retry and for reusing a rejected server flight during hydration before retrying it. The client and server suites, type checks, and build pass.