Skip to content

fix(action): clear earlier submissions when a void/metadata submission settles - #728

Open
EnesKartal wants to merge 1 commit into
solidjs:nextfrom
EnesKartal:fix/clear-submissions-on-success-725
Open

EnesKartal wants to merge 1 commit into
solidjs:nextfrom
EnesKartal:fix/clear-submissions-on-success-725

Conversation

@EnesKartal

Copy link
Copy Markdown

Fixes #725

Summary

When a \ ormAction\ settles with no
esponse\ (e.g., void,
eload(), or
edirect()\ without data), \settle()\ previously skipped updating
outer.submissions\ entirely, leaving any earlier failed submission for that action at \useSubmissions(action).at(-1).

This change updates \settle()\ in \src/data/action.ts\ so that when
esponse\ is \undefined, any existing
outer.submissions\ entries matching the action's \url\ are cleared (leaving other actions' submissions untouched and avoiding unnecessary signal writes when none exist).

Verification


  • px vitest run: 52 test files, 757 passed (including new regression test in \ est/data/action.spec.ts)
  • \pnpm test:types\ &
    px tsc --noEmit: passed with 0 errors

@changeset-bot

changeset-bot Bot commented Nov 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 664f48b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant