fix(sqlite): honor aliases in RETURNING when naming result columns

internal/endtoend/testdata/returning_aliases/sqlite/query.sql

@@ -0,0 +1,36 @@
+-- name: InsertReturningAliases :one
+INSERT INTO t (name, score) VALUES (?, ?)
+RETURNING id AS new_id, score * 2 AS doubled;
+
+-- name: InsertReturningImplicitAliases :one
+INSERT INTO t (name, score) VALUES (?, ?)
+RETURNING id new_id, score * 2 doubled;
+
+-- name: InsertReturningQuotedAliases :one
+INSERT INTO t (name, score) VALUES (?, ?)
+RETURNING id AS "newId", name AS [label];
+
+-- name: InsertReturningSingleAlias :one
+INSERT INTO t (name, score) VALUES (?, ?)
+RETURNING id AS new_id;
+
+-- name: InsertReturningStarAndAlias :one
+INSERT INTO t (name, score) VALUES (?, ?)
+RETURNING *, score * 2 AS doubled;
+
+-- name: InsertReturningDuplicateAliases :one
+INSERT INTO t (name, score) VALUES (?, ?)
+RETURNING id AS old_id, id AS row_id;
+
+-- name: InsertOnConflictReturningAliases :one
+INSERT INTO t (id, name, score) VALUES (?, ?, ?)
+ON CONFLICT (id) DO UPDATE SET score = excluded.score
+RETURNING id AS new_id, score AS total;
+
+-- name: UpdateReturningAliases :one
+UPDATE t SET score = score + 1 WHERE id = ?
+RETURNING id AS updated_id, score - 1 AS previous;
+
+-- name: DeleteReturningAliases :one
+DELETE FROM t WHERE id = ?
+RETURNING id AS deleted_id, upper(name) AS shout;

internal/endtoend/testdata/returning_aliases/sqlite/schema.sql

@@ -0,0 +1,6 @@
+CREATE TABLE t (
+  id INTEGER PRIMARY KEY,
+  name TEXT NOT NULL,
+  score INTEGER NOT NULL,
+  created TEXT
+);

internal/endtoend/testdata/returning_aliases/sqlite/sqlc.json

@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "engine": "sqlite",
+      "name": "querytest",
+      "schema": "schema.sql",
+      "queries": "query.sql"
+    }
+  ]
+}

internal/engine/sqlite/convert.go

@@ -535,11 +535,16 @@ func (c *cc) convertUpdateStmt(n *meyer.UpdateStmt) ast.Node {
 func (c *cc) convertReturning(cols []*meyer.ResultColumn) *ast.List {
 	list := &ast.List{Items: []ast.Node{}}
 	for _, col := range cols {
-		list.Items = append(list.Items, &ast.ResTarget{
+		target := &ast.ResTarget{
 			Indirection: &ast.List{},
 			Val:         c.convertExpr(col.Expr),
 			Location:    col.Pos(),
-		})
+		}
+		if col.Alias != nil {
+			name := identifier(col.Alias)
+			target.Name = &name
+		}
+		list.Items = append(list.Items, target)
 	}
 	return list
 }