Repository navigation
Fix GetCanonicalPathAsync resolving full path instead of parent - #1864
Open
GitMonkey007 wants to merge 1 commit into
Open
GitMonkey007 wants to merge 1 commit into
GitMonkey007 wants to merge 1 commit into
Conversation
GitMonkey007
requested review from
Rob-Hague,
WojciechNagorski and
drieseng
as code owners
November 9, 2026 00:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1863
First time contributing to this project, relatively trivial, but still a bug I think worth fixing. Discovered this issue when looking at MoveTo vs RenameAsync; I've made the relevant change and tried to adhere to the standards/contributing docs; let me know if I've missed something.
The fix itself just moves the problematic implementation details into shared methods (because they previously differ); I've added some tests again trying to adhere to the style in the project.
AI not used to write the change.