Repository navigation
Generate the docs screenshots with Playwright - #456
Open
Bohreromir wants to merge 1 commit into
Open
Bohreromir wants to merge 1 commit into
Bohreromir wants to merge 1 commit into
Conversation
Coverage Report
File CoverageNo changed files found. |
npm run docs:screenshots builds with .env.test and runs the specs in e2e/docs-screenshots in a separate Playwright project, which writes the images to docs/modules/cockpit/images. The normal E2E run skips them.
Bohreromir
force-pushed
the
docs/screenshots-script
branch
from
November 10, 2026 19:21
fb4ea57 to
fc08ff1
Compare
Bohreromir
marked this pull request as ready for review
November 10, 2026 19:22
dervoeti
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
dervoeti
self-requested a review
November 11, 2026 09:15
dervoeti
reviewed
Nov 11, 2026
dervoeti
left a comment
dervoeti
left a comment
Member
There was a problem hiding this comment.
Basically looks good to me, Claude found one thing that sounds reasonable:
The screenshot depends on the fonts of the machine that runs it (e2e/docs-screenshots/dashboard.spec.ts:56, playwright.config.ts:10). Neither src/app.css nor package.json bundles a font, so the app falls back to the Tailwind system font stack. Every contributor who runs the script will commit a slightly different binary and the docs will keep changing look.
Fix:
- Option 1: run the docs project in the official Playwright container (mcr.microsoft.com/playwright:v<same version as @playwright/test>-noble).
- Option 2: bundle a web font.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a script to update screenshots automatically with
npm run docs:screenshotsDocs
Release note
Checklist
Author
Reviewer
Acceptance